Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Traits no longer show up in VSCode workspace symbol search #15444

Closed
cart opened this issue Aug 11, 2023 · 1 comment · Fixed by #15445
Closed

Traits no longer show up in VSCode workspace symbol search #15444

cart opened this issue Aug 11, 2023 · 1 comment · Fixed by #15445
Labels
C-bug Category: bug

Comments

@cart
Copy link

cart commented Aug 11, 2023

rust-analyzer version: 0.3.1615-standalone

rustc version: 1.71.0

relevant vscode settings

// relevant fields from settings.json
"rust-analyzer.imports.prefix": "crate",
"rust-analyzer.cargo.buildScripts.enable": true,
"rust-analyzer.procMacro.enable": true,
"rust-analyzer.inlayHints.parameterHints.enable": false,
"rust-analyzer.inlayHints.chainingHints.enable": false,
"rust-analyzer.inlayHints.maxLength": 15,
"rust-analyzer.imports.group.enable": false,
"rust-analyzer.check.features": "all",

vscode version: 1.81.1

OS: Debian Sid

Traits are no longer showing up for me in workspace symbol search. For example in the serde repo, if I search for Serialize, I only get non-trait results:

image

I've observed this in every repo I try (bevy, bevy_proto, etc). This used to work fine, but recently it has stopped working.

@cart cart added the C-bug Category: bug label Aug 11, 2023
@Veykril
Copy link
Member

Veykril commented Aug 12, 2023

Very odd, it does not seem to be all traits, but most of them ...

bors added a commit that referenced this issue Aug 12, 2023
fix: Fix `only_types` config filtering out traits from world symbols

It is a bit confusing that this apparently did not filter every trait out though...

Closes #15444
@bors bors closed this as completed in 6cf06c1 Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants