Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add into_to_qualified_from assist #15573

Merged
merged 1 commit into from Sep 8, 2023

Conversation

alibektas
Copy link
Member

fixes #15539. This assist converts an .into() call into an explicit fully qualified from() call.

This assist converts an `.into()` call into an explicit
fully qualified from call.
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 7, 2023
@alibektas
Copy link
Member Author

Since it is not a big feature, I had a hard time adding tests :) Open to suggestions on that.

@Veykril
Copy link
Member

Veykril commented Sep 8, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 8, 2023

📌 Commit 9762f76 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Sep 8, 2023

⌛ Testing commit 9762f76 with merge 47e0d07...

@bors
Copy link
Collaborator

bors commented Sep 8, 2023

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 47e0d07 to master...

@bors bors merged commit 47e0d07 into rust-lang:master Sep 8, 2023
10 checks passed
@lnicola lnicola changed the title assist : into_to_qualified_from feat: add into_to_qualified_from assist Sep 9, 2023
@Kmeakin
Copy link

Kmeakin commented Sep 12, 2023

@alibektas thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: assist to convert between x.into() and T::from(x)
5 participants