-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
internal: Stop eagerly resolving inlay hint text edits for VSCode #16473
internal: Stop eagerly resolving inlay hint text edits for VSCode #16473
Conversation
You might need to rebase to fix the CI. @davidbarsky what VS Code are you on? |
1.78 right now, but 1.82 in a week or so. We can carry this as a patch, need be. |
072005a
to
6682b74
Compare
Fwiw there is version field in the |
I'm not in a rush and can hold this PR, as the whole point of it was to get rid of any code-specific checks. But if you want to have it nonetheless, let me know and I will push more checks on top. |
After microsoft/vscode#193124 was fixed, this change is not needed anymore.
f5df64b
to
913e8e2
Compare
Rebased (because of clippy issues that were fixed on master) and made the check conditional on the vscode version s owe can just merge it now. |
913e8e2
to
0dbaccd
Compare
Thanks! |
☀️ Test successful - checks-actions |
Looking at the upstream VS Code commit microsoft/vscode@8adf59f, I think the fix shipped in VS Code 1.86 FWIW. |
1.86 is what the code in the PR checks for |
Send less json over the wire.
After microsoft/vscode#193124 was fixed, this change is not needed anymore.
VSCode 1.86.0 now supports double click for unresolved hint data too.