Try caching macro calls more aggressively in Semantics #17004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Veykril
changed the title
|
☔ The latest upstream changes (presumably #17092) made this pull request unmergeable. Please resolve the merge conflicts. |
Veykril
added
S-waiting-on-author
Veykril
force-pushed
the
ide-macro-caching
branch
2 times, most recently
from
ae62c8c
to
f55e74e
Compare
Veykril
force-pushed
the
ide-macro-caching
branch
3 times, most recently
from
1b5d608
to
a3b3127
Compare
Veykril
force-pushed
the
ide-macro-caching
branch
from
a3b3127
to
7d40763
Compare
Veykril
force-pushed
the
ide-macro-caching
branch
from
8ca2fe0
to
9349045
Compare
|
@bors r+ |
|
☀️ Test successful - checks-actions |
This was referenced Jun 11, 2024
|
@Veykril dumb question: why is this cached outside of salsa? Do you have a good rule of thumb for deciding which state should be in salsa versus in the struct directly like this example? |
|
Most of the state here depends on syntax trees, those have no business being inside salsa because they are heavy memory wise and very unstable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.