-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Make generate function assist generate a function as a constructor if the generated function has the name "new" and is an asscociated function. #17138
Merged
bors
merged 1 commit into
rust-lang:master
from
Kohei316:generate-function-assist-for-new
Apr 30, 2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Apr 25, 2024
Kohei316
force-pushed
the
generate-function-assist-for-new
branch
2 times, most recently
from
April 25, 2024 12:56
3a7e55e
to
44800d1
Compare
Veykril
reviewed
Apr 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A test case with a new
function that takes arguments would be nice as well (which I don't think this change here handles)
Veykril
added
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 29, 2024
… the name of function is new
Kohei316
force-pushed
the
generate-function-assist-for-new
branch
from
April 30, 2024 08:03
44800d1
to
ff2629d
Compare
Veykril
added
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Apr 30, 2024
Veykril
approved these changes
Apr 30, 2024
Thanks! |
☀️ Test successful - checks-actions |
This was referenced May 9, 2024
This was referenced May 28, 2024
This was referenced Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #17050
This PR makes
generate function assist
generate a function as a constructor if the generated function has the name "new" and is an asscociated function.If the asscociate type is a record struct, it generates the constructor like this.
If the asscociate type is a tuple struct, it generates the constructor like this.
If the asscociate type is a unit struct, it generates the constructor like this.
If the asscociate type is another adt, it generates the constructor like this.