Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Make generate function assist generate a function as a constructor if the generated function has the name "new" and is an asscociated function. #17138

Merged
merged 1 commit into from Apr 30, 2024

Conversation

Kohei316
Copy link
Contributor

@Kohei316 Kohei316 commented Apr 25, 2024

close #17050
This PR makes generate function assist generate a function as a constructor if the generated function has the name "new" and is an asscociated function.
If the asscociate type is a record struct, it generates the constructor like this.

impl Foo {
    fn new() -> Self {
        Self { field_1: todo!(), field_2: todo!() }
    } 
}

If the asscociate type is a tuple struct, it generates the constructor like this.

impl Foo {
    fn new() -> Self {
        Self(todo!(), todo!())
    } 
}

If the asscociate type is a unit struct, it generates the constructor like this.

impl Foo {
    fn new() -> Self {
        Self
    } 
}

If the asscociate type is another adt, it generates the constructor like this.

impl Foo {
    fn new() -> Self {
        todo!()
    } 
}

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 25, 2024
@Kohei316 Kohei316 force-pushed the generate-function-assist-for-new branch 2 times, most recently from 3a7e55e to 44800d1 Compare April 25, 2024 12:56
Copy link
Member

@Veykril Veykril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A test case with a new function that takes arguments would be nice as well (which I don't think this change here handles)

@Veykril Veykril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 29, 2024
@Kohei316 Kohei316 force-pushed the generate-function-assist-for-new branch from 44800d1 to ff2629d Compare April 30, 2024 08:03
@Veykril Veykril added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 30, 2024
@Kohei316 Kohei316 requested a review from Veykril April 30, 2024 08:24
@Veykril
Copy link
Member

Veykril commented Apr 30, 2024

Thanks!
@bors r+

@bors
Copy link
Collaborator

bors commented Apr 30, 2024

📌 Commit ff2629d has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Apr 30, 2024

⌛ Testing commit ff2629d with merge 84ef3cf...

@bors
Copy link
Collaborator

bors commented Apr 30, 2024

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 84ef3cf to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate function for Foo::new should assume a Self return type
4 participants