Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: Lazier macro parse tree validation #17221

Merged
merged 2 commits into from
May 13, 2024

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented May 13, 2024

No description provided.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 13, 2024
@Veykril
Copy link
Member Author

Veykril commented May 13, 2024

@bors r+

@bors
Copy link
Collaborator

bors commented May 13, 2024

📌 Commit caddccc has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented May 13, 2024

⌛ Testing commit caddccc with merge b98690b...

@bors
Copy link
Collaborator

bors commented May 13, 2024

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing b98690b to master...

@bors bors merged commit b98690b into rust-lang:master May 13, 2024
11 checks passed
@Veykril Veykril deleted the lazier-validation branch May 13, 2024 15:29
@davidbarsky
Copy link
Contributor

On the project/file that @Wilfred and I were benchmarking and reported in this topic, this resulted in about a 3–5 second speedup:

  • lazy validation, with cache priming: 22311ms fetch_native_diagnostics
  • lazy validation, no cache priming: 43259ms fetch_native_diagnostics
  • eager validation, no cache priming: 48863ms fetch_native_diagnostics
  • eager validation, with cache priming: 25229ms fetch_native_diagnostics

(When I say "lazy validation", I'm referring to the changes introduced by this PR. "eager validation" was a rust-analyzer without these changes.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants