Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce MacroDefKind::CustomDerive #3692

Merged
merged 6 commits into from
Mar 25, 2020
Merged

Introduce MacroDefKind::CustomDerive #3692

merged 6 commits into from
Mar 25, 2020

Conversation

edwin0cheng
Copy link
Member

@edwin0cheng edwin0cheng commented Mar 23, 2020 •
edited
Loading

This PR introduce a new MacroDefKind CustomDerive. And use a new ProcMacroExpander for its expanding. And the expander is a dummy for now.

Related: #3654

@edwin0cheng edwin0cheng mentioned this pull request Mar 23, 2020
Closed
2 tasks
@edwin0cheng
Copy link
Member Author

I move the code to DefCollector::collect and change it to merely register an array of MacroExpander which passed from CrateGraph (Right now it is empty).

@matklad
Copy link
Member

matklad commented Mar 25, 2020

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 25, 2020

Build succeeded

@bors bors bot merged commit 8d667bb into rust-lang:master Mar 25, 2020
@edwin0cheng edwin0cheng deleted the proc-macro-collect branch March 25, 2020 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matklad matklad matklad left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edwin0cheng @matklad