-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tasks.json Support #4096
tasks.json Support #4096
Conversation
Move the task provider anonymous class into a real class, as this seems to be how Microsoft do this in their documentation. resolveTask is now implemented, which is used by VSCode to determine how to execute tasks that the user has defined in tasks.json.
Turns out I didn't need much time to fix this :). |
bors r+ Thanks! |
Build succeeded: |
@jcdickinson Is this a bad place to ask a question related to
But it's ignoring the default task, and just popping up the "Select the build task to run" palette menu and showing "There are task errors. See the output for details." where the Output console says:
Can there be a default for (And again, sorry if this isn't the best spot for the question, I can also move it to an issue if it belongs there.) |
@Keavon you will have to build the extension from source, or wait for an update on the VSCode extension store. The nightly setting wouldn't even help here, as that doesn't govern the version of the extension (it only covers the language server version). |
@jcdickinson I see, so it's a matter of the extension updating now the language server. And to clarify, the issue I was having is fixed now, just not yet deployed to the VS Code extension store? I don't quite understand what this merge request is about, but does it fix the problem I described? Once the web store updates, what behavior will I see? Thanks! |
@Keavon you can download the VSIX from the updates page and manually install it to try out the changes. |
Move the task provider anonymous class into a real class, as this seems to be how Microsoft do this in their documentation.
resolveTask is now implemented, which is used by VSCode to determine how to execute tasks that the user has defined in tasks.json.
Resolves #3983