Correctly generate new struct field in file containing struct def #4996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimoFreiberg
changed the title
TimoFreiberg
commented
Jun 22, 2020
TimoFreiberg
commented
Jun 22, 2020
crates/ra_ide/src/diagnostics.rs
Outdated
| (analysis, pos.file_id) | ||
| } else { | ||
| single_file(before) | ||
| }; | ||
| let diagnostic = analysis.diagnostics(file_id).unwrap().pop().unwrap(); |
There was a problem hiding this comment.
the test fails because there are no diagnostics, so I guess something is broken with the fixture handling.
TimoFreiberg
force-pushed
the
struct-field-file-fix
branch
from
4bcaabe
to
891129c
Compare
TimoFreiberg
force-pushed
the
struct-field-file-fix
branch
from
891129c
to
00fb851
Compare
TimoFreiberg
changed the title
TimoFreiberg
force-pushed
the
struct-field-file-fix
branch
3 times, most recently
from
38fb2aa
to
43079ba
Compare
|
bors r+ Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP because the test doesn't pass.
Testing the fix by hand looked good, although quickfixes seem to not support setting the editor cursor yet, which i think we want for "generate missing defs from usage" fixes.