Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace ad hocery with science #5255

Merged
merged 1 commit into from
Jul 7, 2020
Merged

Replace ad hocery with science #5255

merged 1 commit into from
Jul 7, 2020

Conversation

matklad
Copy link
Member

@matklad matklad commented Jul 7, 2020

bors r+
🤖

bors bot added a commit that referenced this pull request Jul 7, 2020
@bors @matklad
Merge #5255
16bfcc1 
5255: Replace ad hocery with science r=matklad a=matklad



bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jul 7, 2020

Build failed:

@matklad
Copy link
Member Author

matklad commented Jul 7, 2020

bors r+

bors bot added a commit that referenced this pull request Jul 7, 2020
@bors @matklad
Merge #5255
753828e 
5255: Replace ad hocery with science r=matklad a=matklad



bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jul 7, 2020

Build failed:

@matklad
Copy link
Member Author

matklad commented Jul 7, 2020

bors r+

bjorn3
bjorn3 reviewed Jul 7, 2020
View reviewed changes
crates/ra_project_model/src/sysroot.rs
@@ -126,7 +126,6 @@ core
alloc
collections
libc
panic_unwind
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this removed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's already one bellow (hence the dedup call in fst construction code, just to be safe :D)

@bors
Copy link
Contributor

bors bot commented Jul 7, 2020

Build succeeded:

@bors bors bot merged commit 41feb81 into rust-lang:master Jul 7, 2020
@matklad matklad deleted the science branch July 7, 2020 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjorn3 bjorn3 bjorn3 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matklad @bjorn3