Thread varargs through rust-analyzer #5378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flodiebold
approved these changes
Jul 14, 2020
| @@ -30,7 +30,7 @@ impl ToChalk for Ty { | |||
| Ty::Apply(apply_ty) => match apply_ty.ctor { | |||
| TypeCtor::Ref(m) => ref_to_chalk(db, m, apply_ty.parameters), | |||
| TypeCtor::Array => array_to_chalk(db, apply_ty.parameters), | |||
| TypeCtor::FnPtr { num_args: _ } => { | |||
| TypeCtor::FnPtr { num_args: _, is_varargs: _ } => { | |||
There was a problem hiding this comment.
this might be a problem since function pointers will lose their varargness if they go through Chalk. should probably be fine for now though, but at least a FIXME would be good. Alternatively, you could do is_varargs: false here, then the varargs case would be handled by interning the type constructor (basically treating the type like a struct), which would mean that varargness would be preserved, but vararg function pointers wouldn't be treated as function pointers by Chalk.
Chalk issue tracking this: rust-lang/chalk#507
There was a problem hiding this comment.
Okay, FIXME added
|
bors r=flodiebold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a varargs flag to various data structures and fills it from the AST.
Fixes #5374
cc @flodiebold for the typesystem/chalk changes