Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly complete items with leading underscore #6127

Merged
merged 1 commit into from
Oct 5, 2020
Merged

Correctly complete items with leading underscore #6127

merged 1 commit into from
Oct 5, 2020

Conversation

fmease
Copy link
Member

@fmease fmease commented Oct 3, 2020 •
edited
Loading

Fixes #6091. Let me know if the test is placed into the right file or if it is even desired.

@SomeoneToIgnore
Copy link
Contributor

I think it's a good place for a test and it's not a big issue to move it later, if somebody decides to do so.

Thank you.

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 5, 2020

Build succeeded:

@bors bors bot merged commit 44587d1 into rust-lang:master Oct 5, 2020
@fmease fmease deleted the correctly-complete-underscore-prefixed-items branch October 6, 2020 00:38
@lnicola lnicola mentioned this pull request Oct 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Completing items with leading underscore results in two underscores
3 participants
@fmease @SomeoneToIgnore @lnicola