Check for allow(..) attributes in case check diagnostic #6421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popzxc
force-pushed
the
case-check-allow
branch
from
e645cab
to
962926a
Compare
bjorn3
reviewed
Oct 31, 2020
matklad
reviewed
Nov 2, 2020
|
✌️ popzxc can now approve this pull request. To approve and merge a pull request, simply reply with |
popzxc
force-pushed
the
case-check-allow
branch
from
0ff4e8e
to
dd2febf
Compare
|
bors r+ |
This was referenced Nov 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6348
This is not a full-fledged solution, as it doesn't looks up for parent elements (e.g. function -> module -> parent module -> crate root), but it does at least checks attributes of item being checked.
I played a bit with code, and it seems that implementing a proper solution (which will also check for
deny/warnattributes overriding values forallows from above).So, this solution should fix all the macros which intentionally do "weird" naming and wrap it with
allow, such aslazy_static.cc @ArifRoktim