More macro diagnostics improvements #6700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! Although, I have one terminology suggestion -- elsewhere, we are using |
|
Yeah, sounds reasonable. Though I think of a diagnostic as something that is specifically meant to be displayed to the user, not these more internal errors. |
|
bors r+ |
|
I am fine either way!
…On Thu, 3 Dec 2020 at 19:52, Jonas Schievink ***@***.***> wrote:
Yeah, sounds reasonable. Though I think of a diagnostic as something that
is specifically meant to be displayed to the user, not these more internal
errors.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#6700 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANB3M5VMWMZKLOOWMSLIRDSS666PANCNFSM4UK4SWNQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This threads macro expansion errors through
eager.rsand theAsMacroCalltrait, improving macro diagnostics emitted during body lowering.