Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove documentation of obsolete extend selection command #7727

Merged
merged 1 commit into from
Feb 20, 2021

Conversation

lnicola
Copy link
Member

@lnicola lnicola commented Feb 20, 2021

Closes #7454

This is available in LSP as textDocument/selectionRange and no longer exists as a stand-alone command, so we shouldn't mention it in the manual because it's confusing (it doesn't appear in package.json).

@lnicola
Copy link
Member Author

lnicola commented Feb 20, 2021

r? @kjeremy

@matklad
Copy link
Member

matklad commented Feb 20, 2021

I do think it's valuable to keep this documented in the manually, but it makes sense to be more clear that, in VS Code, this maps to a built-in command

@lnicola
Copy link
Member Author

lnicola commented Feb 20, 2021

Updated

@matklad
Copy link
Member

matklad commented Feb 20, 2021

bors r+

would be good to unify features format to show both the shortcut and the action name.

@bors
Copy link
Contributor

bors bot commented Feb 20, 2021

@bors bors bot merged commit de67469 into rust-lang:master Feb 20, 2021
@lnicola lnicola deleted the rm-extend-selection branch February 20, 2021 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Extend selection" should be called "expand"
2 participants