Dynamically apply highlightingOn config #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors r+ Thanks! |
bors bot
added a commit
that referenced
this pull request
Dec 20, 2018
302: Support tracing lsp requests. r=matklad a=DJMcNab TODO: Debug why decorations are sent even when highlightingOn is disabled This makes the log volume so high its impossible to work with anyway. (Continuation of #84 [#99 only disabled using it, not making sure we don't send it]). These logs can be used in https://microsoft.github.io/language-server-protocol/inspector/ Co-authored-by: DJMcNab <36049421+djmcnab@users.noreply.github.com>
bors bot
added a commit
that referenced
this pull request
Dec 24, 2018
302: WIP: Support tracing lsp requests. r=DJMcNab a=DJMcNab EDIT: We need to work out a better way to handle settings before this can be merged. Help wanted TODO: Debug why decorations are sent even when highlightingOn is disabled This makes the log volume so high its impossible to work with anyway. (Continuation of #84 [#99 only disabled using it, not making sure we don't send it]). These logs can be used in https://microsoft.github.io/language-server-protocol/inspector/ Co-authored-by: DJMcNab <36049421+djmcnab@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #84