Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VSCode: apply highlightOn setting without a restart #84

Closed
aochagavia opened this issue Oct 1, 2018 · 0 comments
Closed

VSCode: apply highlightOn setting without a restart #84

aochagavia opened this issue Oct 1, 2018 · 0 comments

Comments

@aochagavia
Copy link
Contributor

https://github.com/matklad/rust-analyzer/pull/83 introduced a vscode setting that makes it possible to disable rust analyzer's syntax highlighting. This setting is applied when the extension is initialized, which means that changes only take effect upon restarting vscode. It would be nice to apply changes to this settings in real time, instead of requiring a restart.

I plan to write a PR for this in the future days, but if anyone else wants to fix this just go for it and open a PR!
@aochagavia aochagavia mentioned this issue Oct 6, 2018
Merged
bors bot added a commit that referenced this issue Oct 7, 2018
@bors @aochagavia
Merge #99
aa30929 
99: Dynamically apply highlightingOn config r=matklad a=aochagavia

Fixes #84

Co-authored-by: Adolfo Ochagavía <aochagavia92@gmail.com>
@bors bors bot closed this as completed in #99 Oct 7, 2018
@DJMcNab DJMcNab mentioned this issue Dec 20, 2018
Merged
bors bot added a commit that referenced this issue Dec 20, 2018
@bors @DJMcNab
Merge #302
bc44e4e 
302: Support tracing lsp requests. r=matklad a=DJMcNab

TODO: Debug why decorations are sent even when highlightingOn is disabled
This makes the log volume so high its impossible to work with anyway.
(Continuation of #84 [#99 only disabled using it, not making sure we don't send it]).

These logs can be used in https://microsoft.github.io/language-server-protocol/inspector/

Co-authored-by: DJMcNab <36049421+djmcnab@users.noreply.github.com>
bors bot added a commit that referenced this issue Dec 24, 2018
@bors @DJMcNab
Merge #302
b052059 
302: WIP: Support tracing lsp requests. r=DJMcNab a=DJMcNab

EDIT: We need to work out a better way to handle settings before this can be merged. Help wanted

TODO: Debug why decorations are sent even when highlightingOn is disabled
This makes the log volume so high its impossible to work with anyway.
(Continuation of #84 [#99 only disabled using it, not making sure we don't send it]).

These logs can be used in https://microsoft.github.io/language-server-protocol/inspector/

Co-authored-by: DJMcNab <36049421+djmcnab@users.noreply.github.com>
@sify21 sify21 mentioned this issue Sep 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aochagavia