Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to a newer version of bitvec #1311

Closed
Fiono11 opened this issue May 13, 2021 · 7 comments
Closed

Upgrade to a newer version of bitvec #1311

Fiono11 opened this issue May 13, 2021 · 7 comments
Milestone

Comments

@Fiono11
Copy link

Fiono11 commented May 13, 2021

Any prevision of when the crate will be updated to a newer version of bitvec?

@ValHeimer
Copy link

I would need this too, because when I try to run "cargo tarpaulin" on my crate (using nom) with Rust 1.52.1, I have the following error:

error: Broken pipe (or error 32)
error: could not compile `bitvec`
ERROR: cargo_tapaulin: Failed to compile tests! Error: cannot find attribute `skip` in this scope

and I hope (let me hope) that it will fix this issue :)

@orhun
Copy link

orhun commented May 20, 2021

Same issue with the tarpaulin here.

@ValHeimer
Copy link

I would need this too, because when I try to run "cargo tarpaulin" on my crate (using nom) with Rust 1.52.1, I have the following error:

error: Broken pipe (or error 32)
error: could not compile `bitvec`
ERROR: cargo_tapaulin: Failed to compile tests! Error: cannot find attribute `skip` in this scope

and I hope (let me hope) that it will fix this issue :)

@orhun seems to be a Tarpaulin issue, in fact... xd009642/tarpaulin#756

@Geal
Copy link
Collaborator

Geal commented Jun 19, 2021

erf, that tarpaulin issue is caused by nom xd009642/tarpaulin#756 (comment)
and appears in nom's CI too https://github.com/Geal/nom/runs/2865070181?check_suite_focus=true

@damccull
Copy link

damccull commented Jun 29, 2021

This doesn't happen for me on wsl2 but it's happening with actions-rs on github actions. Anyone know how to fix?

Edit:
Turns out this is caused by some change in the toolchain. I can get this to work find with 1.49.0 but not on 1.5.2 or higher.

@edward-shen
Copy link

edward-shen commented Jul 15, 2021

@Geal, would it be possible for you to backport the bitvec dependency update you did in 03a1025 to a 6.2.2 release as well? Propagation of the fix should be a lot easier than a major version bump.

Edit: apologies, it looks like 6.2.1 was the backported fix.

@Geal
Copy link
Collaborator

Geal commented Aug 21, 2021

bitvec input types are now in the nom-bitvec crate, since the release of nom 7: https://crates.io/crates/nom/7.0.0

@Geal Geal closed this as completed Aug 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants