Update lexical-core version to "^0.6". #1101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patches: - rust-bakery#1100 - rust-bakery#1080 - rust-bakery#1066 - And a few upstream issues.
|
Now that 0.7 has been released, it would be a nice addition to this :) |
|
@Razican, eventually, yes, however, v0.7 only has support for Rustc >= 1.37, while v0.6 has support for Rustc >= 1.24 (this is due to dependency restrictions). I would like to avoid any breaking changes in Nom currently, but ideally yes, long-term, that would be ideal :D. |
|
Looks like upgrading to 0.7 is just a bump -- tests still pass. 😄 |
|
thank you for this! I'll probably raise the minimum Rust version for nom 6, so it could switch to v0.7 |
This was referenced Feb 24, 2020
double parser returns unexpected result for the input ". " when the lexical feature is enabled
#1080
Closed
This was referenced Feb 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patches: