Provide shortcut for streaming::char
#1410
Conversation
The hope is that intent is clear enough while reducing syntactic noise. The main ambiguity is `streaming` vs `complete`. I assume `complete` is more common but `streaming` is the more universal one, so I went with that.
| /// assert_eq!(parser(""), Err(Err::Incomplete(Needed::new(1)))); | ||
| /// ``` | ||
| fn parse(&mut self, i: I) -> IResult<I, char, E> { | ||
| crate::character::streaming::char(*self)(i) |
There was a problem hiding this comment.
@Stargateur I figured streaming was a safe default Know of any reason to use complete or concerns with having to pick one over the other?
There was a problem hiding this comment.
Oh this could be a big problem... I guess this make impossible to do your idea. If you force streaming, this make any parser for complete not working and vice versa.
| + crate::traits::InputIter | ||
| + crate::traits::InputLength, | ||
| <I as crate::traits::InputIter>::Item: crate::traits::AsChar, | ||
| E: crate::error::ParseError<I>, |
There was a problem hiding this comment.
It looks like internal is a self-contained core of the crate, not depending on anything else.
- Is it ok to use stuff from outside
internal? - If not, should this
impllive somewhere else, like next tochar?
Once we've decided on how this should look, I'll clean this up and get it implemented for the other types discussed in #1408
There was a problem hiding this comment.
I can't speak for geal but I think it's ok but I would reverse, move code from character::char to here and call this implementation in character::char. Trait are ok but maybe parser is too much. Anyway, this file should probably be call parser anyway.
If not, should this impl live somewhere else, like next to char?
Since this impl Parser for a foreign type I think the correct place is here close to trait definition.
As part of rust-bakery#1410, the name `internal.rs` was discussed and it was brought up that `parser.rs` would provide clearer intent.
As part of rust-bakery#1410, the name `internal.rs` was discussed and it was brought up that `parser.rs` would provide clearer intent.
As part of rust-bakery#1410, the name `internal.rs` was discussed and it was brought up that `parser.rs` would provide clearer intent.
As part of rust-bakery#1410, the name `internal.rs` was discussed and it was brought up that `parser.rs` would provide clearer intent.
As part of rust-bakery#1410, the name `internal.rs` was discussed and it was brought up that `parser.rs` would provide clearer intent.
The hope is that intent is clear enough while reducing syntactic noise.
The main ambiguity is
streamingvscomplete. I assumecompleteismore common but
streamingis the more universal one, so I went withthat.