Allow using arrays as input to alt
#1556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that min-const-generics is stabilized, it's possible to (backwards-compatibly) write a version of `alt` that uses a const array as input instead of being limited to only tuples - this allows us to lift the 21-element limitation on tuples passed to `alt`.
|
Hi, any update on this? I am running into a case where I have a grammar with 35 cases. Obviously this doesnt't work with current nom |
epage
pushed a commit
to epage/winnow
that referenced
this pull request
Jul 30, 2023
Now that min-const-generics is stabilized, it's possible to (backwards-compatibly) write a version of `alt` that uses a const array as input instead of being limited to only tuples - this allows us to lift the 21-element limitation on tuples passed to `alt`. Upstream: rust-bakery/nom#1556
epage
pushed a commit
to epage/winnow
that referenced
this pull request
Jul 30, 2023
Now that min-const-generics is stabilized, it's possible to (backwards-compatibly) write a version of `alt` that uses a const array as input instead of being limited to only tuples - this allows us to lift the 21-element limitation on tuples passed to `alt`. Upstream: rust-bakery/nom#1556
|
there were a few things missing to make the DX on this reasonable, mainly having most parsers return a concrete type instead of a closure, and having a |
Geal
approved these changes
Jul 30, 2023
|
great work @glittershark, thanks! |
glittershark
commented
Jul 31, 2023
| match branch.parse(input.clone()) { | ||
| for branch in &mut self.parser { | ||
| match branch.process::<OM>(input.clone()) { | ||
| //branch.parse(input.clone()) { |
There was a problem hiding this comment.
should this have been committed?
epage
reviewed
Aug 10, 2023
| for branch in &mut self.parser { | ||
| match branch.process::<OM>(input.clone()) { | ||
| //branch.parse(input.clone()) { | ||
| Err(Err::Error(e)) => error = Some(e), |
There was a problem hiding this comment.
This isn't oring the errors but only accepting the last one
|
good catch, fixed in 8c68e22 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that min-const-generics is stabilized, it's possible to (backwards-compatibly) write a version of
altthat uses a const array as input instead of being limited to only tuples - this allows us to lift the 21-element limitation on tuples passed toalt.