Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New subcommand for plotting bam files #156

Merged
merged 26 commits into from
Jul 7, 2021

Conversation

fxwiegand
Copy link
Contributor

@fxwiegand fxwiegand commented Jun 9, 2021

This PR introduces a new subcommand rbt plot-bam that allows the user to generate vega-lite plots (à la rbt vcf-report) from given bam file(s) and a fasta reference. An example usage would be:

rbt plot-bam -b /path/to/my.bam  -b /path/to/my_other.bam --region chr1:3973700-3974000 --reference /path/to/fasta.fa > plot.html

All resulting plots are self contained in a single html file for easy exchange with, for example, fellow researches.

Todos:

  • Basic functionality
  • Support for multiple bam files

@fxwiegand fxwiegand marked this pull request as ready for review June 22, 2021 15:25
@fxwiegand fxwiegand removed the WIP label Jun 22, 2021
src/cli.rs Outdated Show resolved Hide resolved
src/cli.rs Outdated Show resolved Hide resolved
@tedil
Copy link
Member

tedil commented Jun 24, 2021

Sorry for hijacking your PR. I initially only wanted to fix a small issue that I encountered, but this snowballed quite a lot. I should have separated this into a different PR, but here we are...

@fxwiegand
Copy link
Contributor Author

Sorry for hijacking your PR. I initially only wanted to fix a small issue that I encountered, but this snowballed quite a lot. I should have separated this into a different PR, but here we are...

No problem! If the code benefits (almost) everything is fine for me 👍

tedil
tedil previously approved these changes Jul 2, 2021
@tedil tedil dismissed their stale review July 2, 2021 09:07

self-reviews shouldn't be allowed!

@johanneskoester johanneskoester changed the title New subcommand for plotting bam files feat: New subcommand for plotting bam files Jul 7, 2021
@johanneskoester johanneskoester merged commit 707ef77 into rust-bio:master Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants