Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Update xlsxwriter due to compilation error with older version #257

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

fxwiegand
Copy link
Contributor

This PR updates xlsxwriter due to compilation error with older version and fixes #256.

Copy link
Member

@dlaehnemann dlaehnemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, very minimal changes and great that this immediately fixes an issue!

As an afterthought: Maybe we want to activate dependabot on this repo at some point...

@dlaehnemann dlaehnemann merged commit 0ffaf4d into master Jul 24, 2023
5 checks passed
@dlaehnemann dlaehnemann deleted the update-xlsxwriter branch July 24, 2023 13:29
@fxwiegand
Copy link
Contributor Author

LGTM, very minimal changes and great that this immediately fixes an issue!

As an afterthought: Maybe we want to activate dependabot on this repo at some point...

Yes absolutely agree on that thought! It has been working great for us the last months on datavzrd, alignoth etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xlsxwriter v0.3.5 compiling failed
2 participants