Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix '\' being rendered as ’' on docs.rs #31

Merged
merged 2 commits into from
Nov 17, 2021

Conversation

RagnarGrootKoerkamp
Copy link
Contributor

@RagnarGrootKoerkamp RagnarGrootKoerkamp commented Nov 15, 2021

Before, this would render as two quotes since the \ escapes the closing quote. Escaping the backslach itself should fix this.

Could also add (a single backslash) to clarify it for those reading the source instead of the online docs.

Before, this would render as two quotes since the `\` escapes the closing quote. Escaping the backslach itself should fix this.
@fxwiegand fxwiegand changed the title Fix '\' being rendered as ’' on docs.rs fix: Fix '\' being rendered as ’' on docs.rs Nov 15, 2021
@coveralls
Copy link

coveralls commented Nov 15, 2021

Pull Request Test Coverage Report for Build 1470561482

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 9 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+1.0%) to 73.814%

Files with Coverage Reduction New Missed Lines %
src/annot/loc.rs 1 63.64%
src/annot/pos.rs 1 76.55%
src/alignment.rs 2 85.98%
src/annot/contig.rs 2 71.6%
src/annot/spliced.rs 3 78.59%
Totals Coverage Status
Change from base Build 1323922217: 1.0%
Covered Lines: 778
Relevant Lines: 1054

💛 - Coveralls

Copy link
Contributor

@dcroote dcroote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could also add (a single backslash) to clarify it for those reading the source instead of the online docs.

I think this would be helpful. Otherwise nice catch 👍

@RagnarGrootKoerkamp
Copy link
Contributor Author

@dcroote Done!

@dcroote
Copy link
Contributor

dcroote commented Nov 17, 2021

LGTM!

@dcroote dcroote merged commit ebbb67a into rust-bio:master Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants