New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: include doctests
in the test coverage of code that tarpaulin calculates
#533
fix: include doctests
in the test coverage of code that tarpaulin calculates
#533
Conversation
…copying rust-htslib approach
…b.com:rust-bio/rust-bio into include-doctests-in-code-coverage-calculation
for nightly, caching is not very useful, see: https://github.com/marketplace/actions/rust-cache#cache-effectiveness
…with rust-htslib these are probably not needed...
…argument back in
…e --timeout for it to 30 minutes
…are still compiled)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks quite reasonable to me ;)
I guess while there is a way to somehow mock stdin for doctests, it is not a big issue for now. We could of course manually replace stdin in the examples with some fixed input in the future.
I guess as an example, the stdin-construct is useful as well. So I'm also not overly concerned about this. |
What a heroic effort @dlaehnemann ! |
Thanks for the kind words! 😅 It did take me a while to figure out that
I condensed this down to something like (I think -- I didn't record it while doing it, so this is from memory):
Also, the setting of |
Using a syntax found here:
xd009642/tarpaulin#538 (comment)
We are also using this in
rust-htslib
, now.