Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encodable and Decodable should be named Encode and Decode #1741

Open
Kixunil opened this issue Mar 23, 2023 · 3 comments · May be fixed by #2184
Open

Encodable and Decodable should be named Encode and Decode #1741

Kixunil opened this issue Mar 23, 2023 · 3 comments · May be fixed by #2184
Labels
1.0 Issues and PRs required or helping to stabilize the API API break This PR requires a version bump for the next release

Comments

@Kixunil
Copy link
Collaborator

Kixunil commented Mar 23, 2023

The trait names in Rust are verbs, not adjectives. But before we rename it I would like to see if there's a benefit of keeping some kind of compatibility layer once we implement push-based decoding or custom IO traits.
@Kixunil Kixunil added API break This PR requires a version bump for the next release 1.0 Issues and PRs required or helping to stabilize the API labels Mar 23, 2023
@Harshil-Jani
Copy link
Contributor

@Kixunil Any updates on this ? Let me know if I can volunteer a patch to do it if community feels that it is needed.

@Kixunil
Copy link
Collaborator Author

Kixunil commented May 16, 2023

Please wait with it.

@tcharding tcharding mentioned this issue Jun 1, 2023
Closed
@stevenroose
Copy link
Collaborator

I don't have a problem with Encodable and Decodable.

@Kixunil Kixunil linked a pull request Jan 21, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1.0 Issues and PRs required or helping to stabilize the API API break This PR requires a version bump for the next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

push-based decoding Kixunil/rust-bitcoin
3 participants
@stevenroose @Kixunil @Harshil-Jani