New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bitcoin: Set version number #2729
Conversation
Pull Request Test Coverage Report for Build 8930774910Details
💛 - Coveralls |
d4256c8
to
5666b72
Compare
Can we set it to 0.32.99, or 0.33.0-rc.0 or something, so it's clear that we're incompatible (or soon will be) with the recent 0.32 release? |
Is that something we want to do across the all our crates? It implies an additional PR right after release of every crate. Now I think about it it does give us a nice checkpoint for doing other "this should be done as the first thing after release" things which have come up before, we can do the "set version to x.y.z-pre-release" and make the PR depend on other PRs same as we do for release tracking PRs? |
Any crates for which we have an rc cycle, yes. But I think that might be only this crate (though we should do it in rust-miniscript and maybe rust-secp). Many of our "edge crates" like io, jsonrpc, hex-conservative, etc., we usually just do one-shot releases whenever we need them, and we don't usually have separate release branches. And I think this is fine for those crates. |
No worries, I haven't fully understood the why, as in why would |
I used |
Because
|
In 91eed01: It appears you have changed the commit message but have not changed the diff :) |
Gawwwd damn |
During the recent release cycle we left `bitcoin` on the last rc version. Set the version number to `v0.33.0-unreleased` to make it obvious what it is. Close: rust-bitcoin#2724
Changes were not comited from yesterday :( |
In case you have a suggestion for me, the reason this happens occasionally is (that I'm rushing doing 10 things) because I use the up arrow in the shell to get at I should obviously just slow down and take a breath before pushing ... |
Do we care about users that are testing using master and expect the types to be compatible with other crates that use bitcoin 0.32? |
Oh good observation @sanket1729! This might actually be a feature not a bug, at least when I've been testing rc releases I've specifically changed the version number of all the crates in the stack to force fails if I've missed updating the manifest of some crate and the compiler is still pulling from crates.io - but I'm not 100% sure this is the most time efficient way to do it. If devs are testing master they can also just change the version number locally, right? |
You can use Ctrl+R then
We "care" in the sense that we want them to quickly see compiler errors in case they forget to patch something :). But I think this will happen regardless of version number, because cargo won't consider a crates.io crate to be the same as a local crate. In general |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 46e0ce5
Yeah, that's what I meant about feature-not-bug, we break the API so often ... |
Legend, thanks! |
If you do install atuin, note that it'll default to triggering on both Ctrl+R and up-arrow. The up-arrow behavior is insane and you should just disable it. The docs also talk a big game about being able to upload your shell history to some server, and also they have a server you can use, but don't worry everything is encrypted wink wink. This is also insane and makes me distrust the project, but you can totally ignore this and just install it locally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 46e0ce5
Cheers, I did install it and I did not enable the server feature. I didn't dive any further into it yet though. |
Merge please, has two acks. |
During the recent release cycle we left
bitcoin
on the last rc version.Set the version number to
v0.33.0-unreleased
to make it obvious what it is.Close: #2724