Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update keysend docs + add payment secret requirement for MPP #1038

Merged

Conversation

valentinewallace
Copy link
Contributor

Addressing #967 (comment).

Closes #1026

@codecov
Copy link

codecov bot commented Aug 6, 2021

Codecov Report

Merging #1038 (552a244) into main (8530078) will increase coverage by 1.57%.
The diff coverage is 97.56%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1038      +/-   ##
==========================================
+ Coverage   90.80%   92.37%   +1.57%     
==========================================
  Files          61       62       +1     
  Lines       31582    37644    +6062     
==========================================
+ Hits        28678    34774    +6096     
+ Misses       2904     2870      -34     
Impacted Files Coverage Δ
lightning/src/ln/channelmanager.rs 89.57% <97.56%> (+3.85%) ⬆️
lightning/src/util/errors.rs 69.33% <0.00%> (-2.10%) ⬇️
lightning/src/ln/mod.rs 89.28% <0.00%> (-0.72%) ⬇️
lightning-background-processor/src/lib.rs 95.20% <0.00%> (-0.38%) ⬇️
lightning/src/ln/script.rs 93.75% <0.00%> (ø)
lightning/src/ln/chanmon_update_fail_tests.rs 97.80% <0.00%> (+0.05%) ⬆️
lightning/src/chain/keysinterface.rs 95.58% <0.00%> (+0.21%) ⬆️
lightning/src/ln/functional_test_utils.rs 95.51% <0.00%> (+0.33%) ⬆️
lightning/src/ln/functional_tests.rs 98.97% <0.00%> (+1.65%) ⬆️
lightning/src/chain/channelmonitor.rs 92.71% <0.00%> (+2.14%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8530078...552a244. Read the comment docs.

@TheBlueMatt TheBlueMatt added this to the 0.0.100 milestone Aug 7, 2021
lightning/src/ln/channelmanager.rs Outdated Show resolved Hide resolved
lightning/src/ln/channelmanager.rs Outdated Show resolved Hide resolved
@TheBlueMatt TheBlueMatt merged commit 6a94ff9 into lightningdevkit:main Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reject Keysend/no-PaymentSecret sends with multiple paths
3 participants