Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Non Standard Miniscripts #165

Open
sanket1729 opened this issue Nov 4, 2020 · 1 comment
Open

Support for Non Standard Miniscripts #165

sanket1729 opened this issue Nov 4, 2020 · 1 comment
Labels
brainstorming low-priority Low priority issues that don't require urgent attention

Comments

@sanket1729
Copy link
Member

Miniscript language is designed to be standardness complete, however in certain applications like block explorer may require the ability to parse non-standard Miniscripts.

However, at this point, the current solution to change Miniscript ScriptContext from Generic Type to a parameter in every function seems overly invasive and is not worth the change as lose the strong type guarantees of Miniscript. (For example, using uncompressed keys in segwit context).

Considering the tradeoff that we maybe gaining very little compared by supporting non-standard miniscripts, and that there would be scripts on the blockchain that are not miniscripts which we would not be able to parse anyways, it is probably not worth it to support for those.

Marking this as brainstorming and a low priority issue for now. If there are additional usecases for converting Miniscript<MiniscriptKey, ScriptContext> to Miniscript<MiniscriptKey> we can consider implementing the changes.

@sanket1729 sanket1729 added brainstorming low-priority Low priority issues that don't require urgent attention labels Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brainstorming low-priority Low priority issues that don't require urgent attention
Projects
None yet
Development

No branches or pull requests

2 participants
@sanket1729 and others