Feature: Syscall #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For now, can we skip printing when count is zero with a todo in the code explaining why? Also, if you don't mind opening an issue in rust-bcc - I want to take a deeper look into this. Please link it to this PR for reference. I will review the PR tomorrow. Thanks! |
brayniac
reviewed
Jul 22, 2020
brayniac
reviewed
Jul 22, 2020
brayniac
reviewed
Jul 22, 2020
brayniac
reviewed
Jul 22, 2020
brayniac
reviewed
Jul 22, 2020
brayniac
reviewed
Jul 22, 2020
brayniac
reviewed
Jul 24, 2020
brayniac
reviewed
Jul 24, 2020
brayniac
reviewed
Jul 24, 2020
brayniac
reviewed
Jul 24, 2020
brayniac
approved these changes
Jul 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the iovisor's
syscountcode in rustOnly difference so far between the outputs is that it does not show counts/latency by process. They implemented it by reading
/proc/{pid}/command I'm trying to figure out a way to do it with bpf only. e.g.BPF_HASH(pid, BPF_HASH(..))Possible bug:
The bpf table in rust never seems to be empty. i.e. there would always be an entry with key=0 even after I call delete_all. And syscall=0 maps to
readso you see the following whenever there are no actual values.