Config name #37
Merged
Config name #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 1, 2021 20:41
|
This PR made a breaking change, by changing the arity of the https://github.com/reujab/silver/blob/master/src/main.rs#L17 |
|
@amomchilov ah yeah depending on the master branch directly isnt a good idea and any breaking change can result in breaking changes being emitted downstream. The latest change (of depending on 0.4) is the right move here. We will be releasing this as a new backwards incompatible version (0.5) instead of (0.4.1) so no more changes will be required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on top of #36. So t should be merged after (or in place ?). I wanted to do 1PR per issue resolved.
If needed I can reorder the code to merge in the other order.