-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace is-terminal dep with std::io::IsTerminal #276
Comments
Looks like we don't have a state MSRV policy. My default choice is N-2 but I suspect that env_logger's wider use might make that unappealing. @matthiasbeyer any thoughts? |
Yeah so I would actually keep this crate as backwards compatible as possible within reason. If we currently compile on N-10 or even older, I don't see why we should change that if we do not have some really good reasons. Rationale is that this is, IMO, the go-to crate for "I want logging". It's the lowest-hanging fruit for getting logging to work in a Rust project, at least in my perception. I would like to see this issue resolved, but I think backwards compatibility is more important. I'm open to discussion though. |
|
Another change I'm looking to make, switching from While I'm not a fan of treating MSRV as a breaking change, if its done in conjunction with breakings changes (with a commitment to support old versions if needed), I wonder if that would be sufficient to allow us to move forward with this. |
You can write a build script such that it sets a feature for either is-terminal or std-io-isterminal based on the version in use. That wouldn't be breaking. |
I'd love to see this too. Getting rid of the
|
I've gone ahead with my idea of bundling the MSRV bump with a pre-planned breaking change of switching from See #298 |
https://doc.rust-lang.org/stable/std/io/trait.IsTerminal.html
Needs to wait for MSRV 1.70
The text was updated successfully, but these errors were encountered: