Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI doesn't validate human-panic still works with oldest supported rust version #28

Closed
epage opened this issue Apr 25, 2018 · 0 comments 路 Fixed by #51
Closed

CI doesn't validate human-panic still works with oldest supported rust version #28

epage opened this issue Apr 25, 2018 · 0 comments 路 Fixed by #51

Comments

@epage
Copy link
Collaborator

epage commented Apr 25, 2018

馃悰 bug report

I noticed .travis.yml isn't running tests on the oldest supported version of rust. This makes it harder for users to find what version of rust is supported and makes it easy to accidentally change the oldest supported version without fanfare.

This came up when someone reported to me that they had to upgrade their version of rust to try out human-panic due to a use-statement syntax being used.

See docmatic for an example on how to enforce this.
@spacekookie spacekookie changed the title CI doesn't validate human-panic still works with oldest supported rust versoion CI doesn't validate human-panic still works with oldest supported rust version May 28, 2018
spacekookie added a commit that referenced this issue Oct 4, 2018
@spacekookie
Properly test code on oldest supported rust version
b1d4117 
This PR fixes #28. We don't currently verify `human-panic`
properly works anymore. So this adds running tests on the
oldest version we support (which is 1.25.*)
@spacekookie spacekookie mentioned this issue Oct 4, 2018
Merged
spacekookie added a commit that referenced this issue Oct 4, 2018
@spacekookie
Properly test code on oldest supported rust version
357bba9 
This PR fixes #28. We don't currently verify `human-panic`
properly works anymore. So this adds running tests on the
oldest version we support (which is 1.25.*)
spacekookie added a commit that referenced this issue Oct 4, 2018
@spacekookie
Properly test code on oldest supported rust version
2371645 
This PR fixes #28. We don't currently verify `human-panic`
properly works anymore. So this adds running tests on the
oldest version we support (which is 1.25.*)
spacekookie added a commit that referenced this issue Oct 4, 2018
@spacekookie
Properly test code on oldest supported rust version
43a527e 
This PR fixes #28. We don't currently verify `human-panic`
properly works anymore. So this adds running tests on the
oldest version we support (which is 1.25.*)
spacekookie added a commit that referenced this issue Oct 4, 2018
@spacekookie
Properly test code on oldest supported rust version
d7095dd 
This PR fixes #28. We don't currently verify `human-panic`
properly works anymore. So this adds running tests on the
oldest version we support (which is 1.25.*)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Properly test code on oldest supported rust version rust-cli/human-panic
1 participant
@epage