Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a repository field to the Metadata struct (fixes #77) #78

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Michael-F-Bryan
Copy link

@Michael-F-Bryan Michael-F-Bryan commented Sep 26, 2021

Choose one: this is a 馃檵 feature

This resolves #77 by adding a repository field to the Metadata struct and a corresponding "Repository: ..." line to the message that gets printed

Checklist

  • tests pass
  • tests and/or benchmarks are included
  • documentation is changed or added

Context

See #77.

Semver Changes

This is a breaking change because it adds a field to Metadata, which doesn't have the #[non_exhaustive] attribute.

@Michael-F-Bryan
Copy link
Author

Michael-F-Bryan commented Sep 26, 2021

Note that this repo no longer satisfies its own MSRV because the Cargo.lock file isn't committed and a number of dependencies use newer Rust features.

Compiler errors with Rust 1.36.0
$ cargo +1.36.0 test
  ...
error: cannot find macro `matches!` in this scope
   --> /home/michael/.cargo/registry/src/github.com-1ecc6299db9ec823/rustc-demangle-0.1.21/src/v0.rs:700:20
    |
700 |                 if matches!((quote, c), ('\'', '"') | ('"', '\'')) {
    |                    ^^^^^^^

error: aborting due to previous error

error: Could not compile `rustc-demangle`.
warning: build failed, waiting for other jobs to finish...
error[E0658]: naming constants with `_` is unstable
  --> /home/michael/.cargo/registry/src/github.com-1ecc6299db9ec823/memchr-2.4.1/src/memmem/prefilter/fallback.rs:37:1
   |
37 | const _: PrefilterFnTy = find;
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: for more information, see https://github.com/rust-lang/rust/issues/54912

error[E0658]: naming constants with `_` is unstable
 --> /home/michael/.cargo/registry/src/github.com-1ecc6299db9ec823/memchr-2.4.1/src/memmem/prefilter/x86/sse.rs:9:1
  |
9 | const _: PrefilterFnTy = find;
  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: for more information, see https://github.com/rust-lang/rust/issues/54912

error[E0658]: non exhaustive is an experimental feature
   --> /home/michael/.cargo/registry/src/github.com-1ecc6299db9ec823/memchr-2.4.1/src/memmem/prefilter/mod.rs:152:1
    |
152 | #[non_exhaustive]
    | ^^^^^^^^^^^^^^^^^
    |
    = note: for more information, see https://github.com/rust-lang/rust/issues/44109

error: aborting due to 3 previous errors

I've created #79 to track this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fallback to repository if homepage is absent
2 participants