Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly test code on oldest supported rust version #51

Merged
merged 1 commit into from Oct 4, 2018

Conversation

spacekookie
Copy link
Collaborator

This PR fixes #28. We don't currently verify human-panic
properly works anymore. So this adds running tests on the
oldest version we support (which is 1.25.*)

Copy link
Collaborator

@killercup killercup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also add 1.25.0 as another item in the list with stable and beta at the top

@spacekookie spacekookie force-pushed the improving-travis branch 2 times, most recently from 357bba9 to 2371645 Compare October 4, 2018 18:06
This PR fixes #28. We don't currently verify `human-panic`
properly works anymore. So this adds running tests on the
oldest version we support (which is 1.25.*)
@spacekookie spacekookie merged commit d7095dd into master Oct 4, 2018
@spacekookie spacekookie deleted the improving-travis branch October 4, 2018 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI doesn't validate human-panic still works with oldest supported rust version
2 participants