Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the build for zig 0.11.0 #160

Merged
merged 3 commits into from
Aug 17, 2023
Merged

Fix the build for zig 0.11.0 #160

merged 3 commits into from
Aug 17, 2023

Conversation

haohaolee
Copy link
Contributor

@haohaolee haohaolee commented Aug 16, 2023 •
edited by messense

Based on the discussion #158

  1. use linker rust-lld for linux-musl targets
  2. replace -Wl,-Bdynamic with -Wl,-search_paths_first to workaround another linker issue for windows-gnu targets

Closes #156
Closes #158

messense
messense approved these changes Aug 17, 2023
View reviewed changes
Copy link
Member

@messense messense left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@messense messense merged commit c42649e into rust-cross:main Aug 17, 2023
39 checks passed
@chenrui333 chenrui333 mentioned this pull request Aug 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@messense messense messense approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

musl targets are broken with latest zig (0.11.0)
2 participants
@haohaolee @messense