-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added manual threshold algorithm #56
Conversation
The Manual algorithm is actually just the application of a threshold to the image.
I forgot to add a unit test for the "manual" threshold. However, in going back and implementing the unit test, I realized the "manual" algorithm is just an application of a calculated or determined threshold value. So, I changed the I also refactored the imports for the development to be within the Something to consider is renaming the ...
fn threshold_calculate_otsu(&self) -> Result<f64, Error>;
fn threshold_apply_otsu(&self) -> Result<Self::Output, Error>;
... The |
Sure I'm fine with splitting threshold calculation and application 👍. PR overall looks good so far, if you also update the changelog adding a new |
I have added the Separating out the |
Sure, if you want to make an issue to track it or just go straight into the PR if you want to I'll just give this a last looksie and then merge if it still looks all good |
Simple implementation to apply thresholding with manual lower and upper limits. The auto-thresholding algorithms can be used to automatically select a threshold and apply it, but a function to simply apply user determined limits could be useful.