This repository has been archived by the owner on Jul 7, 2021. It is now read-only.
Do not quote default values #105
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 5, 2021 23:41
Single-quoting the value makes it impossible to use functions. Instead, the quoting should happen in the parameter to default()
|
Updated the PR to do the same for SQLite and MySQL, should now also close #90. |
cschmatzler
changed the title
|
Hey, thanks for this PR. Could you try rebasing your branch? I merged a bunch of PRs that have been open for way too long 🙈 Once that's taken care of I'll merge this without there being any tests for this because I'm planning on rebuilding the entire way that |
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Single-quoting the value makes it impossible to use functions.
Instead, the quoting should happen in the parameter to
default().This should also close #99.