Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add SurrealDB support #295

Closed
wants to merge 3 commits into from

Conversation

TECHNOFAB11
Copy link

@TECHNOFAB11 TECHNOFAB11 commented Dec 2, 2023

adds support for SurrealDB. I had to modify some SQL a bit and add new query constants for Surreal because of its different SurQL syntax.
This uses Surreal for testing, it should act the same like a remote database.

The current tests pass, but the tests with the broken migrations are still missing.

Closes #294

@TECHNOFAB11
Copy link
Author

Seems to work now, tried embedded and cli

@TECHNOFAB11 TECHNOFAB11 marked this pull request as ready for review December 2, 2023 15:07
@jxs
Copy link
Member

jxs commented Dec 4, 2023

Hi, and thanks for this! Recently there was a similar initiative that I think for a couple of reasons lives better outside of this repo, see here for the discussion. Nonetheless I would love you to release this as a separate crate that I would add in the README.md wdyt?

@TECHNOFAB11
Copy link
Author

@jxs Yeah that makes sense. I'll have to see if I find the time to create a self contained crate, if anyone else is interested in doing that please feel free to let me know/feel free to do so

@TECHNOFAB11 TECHNOFAB11 closed this Dec 4, 2023
@jxs jxs mentioned this pull request Jan 12, 2024
@jxs jxs mentioned this pull request Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support SurrealDB
2 participants