Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic migration dicovery, bug fix #313

Merged
merged 4 commits into from
Mar 3, 2024

Conversation

alfred-hodler
Copy link
Contributor

  • Fixes a bug in get_last_applied_migration due to an incorrect SQL query that partially uses dynamic table names and partially hardcodes the default one.

  • Adds a new utility function that enables dynamic migration discovery where embedding is not desirable.

* Fixes a bug in `get_last_applied_migration` due to an incorrect SQL
  query that partially uses dynamic table names and partially hardcodes
  the default one.

* Adds a new utility function that enables dynamic migration discovery
  where embedding is not desirable.
@alfred-hodler alfred-hodler force-pushed the table_name_bug_fix_load_migrations branch from 2b46379 to 78651e5 Compare February 23, 2024 01:12
Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Only one remark

refinery_core/src/util.rs Outdated Show resolved Hide resolved
refinery_core/src/util.rs Outdated Show resolved Hide resolved
@jxs jxs merged commit 83c8cba into rust-db:main Mar 3, 2024
29 checks passed
@jxs
Copy link
Member

jxs commented Mar 3, 2024

Thanks! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants