Attr parsing for #[diplomat::opaque_mut]
#263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QnnOkabayashi
force-pushed
the
improve-diplomat-struct-attrs
branch
from
564bbb5
to
e551507
Compare
Manishearth
approved these changes
Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first PR towards #225.
The first step towards adding opaque_mut is supporting parsing it from the AST. The way we parsed our custom attributes from the AST was a bit of a mess, so this PR improves that mechanism, and then uses the improved version to also support parsing
#[diplomat::opaque_mut]. It then uses this information to set a new flag field inast::OpaqueStructwhen constructed, which dictates whether or not it's an opaque_mut.