WASM Automatic Demo Generator Proof of Concept #500
Conversation
Got classes in place, but we need a workaround.
|
Mixed syntax for arguments, terminusArgs, and ...args. Cleaning up would be helpful, so using the argument names would be better than |
|
Move |
| null, | ||
| [ | ||
| terminusArgs[0] | ||
| ] | ||
| ), |
| (function (...args) { | ||
| let out = new ICU4XFixedDecimalFormatterOptions(); | ||
|
|
||
| out.groupingStrategy = args[0]; | ||
|
|
||
| out.someOtherConfig = args[1]; | ||
|
|
||
| return out; | ||
| }).apply( |
| (function (...args) { | ||
| let out = new ICU4XFixedDecimalFormatterOptions(); | ||
|
|
||
| out.groupingStrategy = args[0]; | ||
|
|
||
| out.someOtherConfig = args[1]; | ||
|
|
||
| return out; | ||
| }).apply( | ||
| null, | ||
| [ | ||
| terminusArgs[1], | ||
| terminusArgs[2] | ||
| ] | ||
| ) |
There was a problem hiding this comment.
Suggestion, if easy:
| (function (...args) { | |
| let out = new ICU4XFixedDecimalFormatterOptions(); | |
| out.groupingStrategy = args[0]; | |
| out.someOtherConfig = args[1]; | |
| return out; | |
| }).apply( | |
| null, | |
| [ | |
| terminusArgs[1], | |
| terminusArgs[2] | |
| ] | |
| ) | |
| (function () { | |
| let out = new ICU4XFixedDecimalFormatterOptions(); | |
| out.groupingStrategy = terminusArgs[1]; | |
| out.someOtherConfig = terminusArgs[2]; | |
| return out; | |
| })() |
| ICU4XFixedDecimal.new_.apply( | ||
| null, | ||
| [ | ||
| terminusArgs[3] |
There was a problem hiding this comment.
Suggestion: If you have enough information to know that "it is the third argument", you probably also know the variable name.
| Some(label) | ||
| } | ||
| }) | ||
| .unwrap_or(param_name.clone()); |
There was a problem hiding this comment.
Suggestion: param_name.clone() could instead use heck to produce a nicer titlecase label
| @@ -10,6 +10,7 @@ pub mod ffi { | |||
| impl ICU4XLocale { | |||
| /// Construct an [`ICU4XLocale`] from a locale identifier represented as a string. | |||
| #[diplomat::attr(supports = constructors, constructor)] | |||
| #[diplomat::demo(input(name(label = "Locale Name")))] | |||
| pub fn new(name: &DiplomatStr) -> Box<ICU4XLocale> { | |||
There was a problem hiding this comment.
Suggestion: name could be changed to locale_name. This improvement could be applied elsewhere, too.
Rough implementation of the process described in https://docs.google.com/document/d/1xRTmK0YtOfuAe7ClN6kqDaHyv5HpdIRIYQW6Zc_KKFU/edit?usp=sharing
Proof of concept is live at https://ambiguous.name/diplomat/