Removed Internal Mutability #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rences in methods
|
I agree with your point about internal mutability being required and the existing API not guaranteeing thread safety, and thus, I am on board with this. @MathiasKoch thoughts? |
|
I think this is okay, assuming we can reach some agreement on #39 as stated in OP |
This was referenced Jan 18, 2021
Closed
thejpster
approved these changes
Jan 18, 2021
ryan-summers
approved these changes
Jan 19, 2021
ryan-summers
requested changes
Jan 19, 2021
There was a problem hiding this comment.
Ah just noticed missing CHANGELOG entry. Mind adding a notice there that we're adding self mutability and reference issue #39 for more detail?
eldruin
approved these changes
Jan 19, 2021
MathiasKoch
approved these changes
Jan 19, 2021
|
Thanks Ryan. I keep forgetting too, maybe we need an Action to check for that. Changelog entry added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed requirement on internal mutability by using mutable self references in methods.
See #39 for details. Should not be merged unless that alternate approach to sharing is approved.
/resolves #39