Fix UK Hash and Backslash mixup #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryan-summers
reviewed
Feb 4, 2023
|
Rather than explain why HashTilde and Backslash are swapped on a UK keyboard, I got a bit carried away and fundamentally reworked how we name Key Codes. |
Now matches https://kbdlayout.info/kbduk/virtualkeys. Also fixes decode of Print Screen and Pause/Break. * BackTick is now Oem8 * Minus is now OemMinus * Equals is now OemPlus * BracketSquareLeft is now Oem4 * BracketSquareRight is now Oem6 * BackSlash is now Oem7 * SemiColon is now Oem1 * Quote is now Oem3 * Enter is now Return * Comma is now OemComma * Fullstop is now OemPeriod * Slash is now Oem2 * NumpadSlash is now NumpadDivide * NumpadStar is now NumpadMultiply * NumpadMinus is now NumpadSubtract * NumpadPlus is now NumpadAdd * ShiftLeft/Right is now LShift/RShift * ControlLeft/Right is now LControl/RControl * AltLeft/Right is now LAlt/RAltGr * RCtrl2 is now a thing (turns NumLock into Pause) * RAlt2 is now a thing (sent as part of Print Screen) * Cleaned up the test cases The KeyCode enum now fits in a `u8`.
jonathanpallant
force-pushed
the
fix-uk-hash
branch
from
233edda
to
fafe0ec
Compare
It makes KeyCodes non-FFI-safe.
ryan-summers
approved these changes
Feb 6, 2023
There was a problem hiding this comment.
I like the changes, but the Oem codes are a bit opaque to me. Which makes sense if every OEM uses them differently.
In any case, I like the changes here. I haven't thoroughly reviewed every key mapping, but I imagine it's easy for us to fix issues as they arise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #25