-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pointer authentication registers #14
Conversation
I have checked these definitions against the Arm Architecture Reference Manual DDI 0487H.a. All good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR!
We don't currently have any maintainers for this repository, so if anyone is interested in helping to review PRs and cut releases, please comment here or chat to me on Matrix, I'd be happy to get you set up.
Please could you fix the rustfmt issues? |
I couldn't see the format difference between the files added in this commit and the existing register files such as ( |
This task failed: https://github.com/rust-embedded/aarch64-cpu/actions/runs/4896918903/jobs/8892258745?pr=14 CI must pass for this PR to be merged. |
The format related issue has been fixed with the latest update. Could you please review and approve to enable the workflow? |
@adamgreig Hi Adam! I'd be happy to help as a maintainer. I'm familiar with the architecture :) |
@nchong-at-aws great, thank you for volunteering! As the crate is owned by the rust embedded working group, would it be OK for you to join? If you open a PR to https://github.com/rust-embedded/wg#the-cortex-a-team to add your name to the list, I will approve it and you will then get access to this repo and to the crate on crates.io. There's no other responsibility beyond this crate. |
Pointer Authentication comes with ARMv8.3-A. This commit adds support for reading and writing 128-bit key registers which are referenced in Arm Architecture Reference Manual for A-profile architecture section D13.2 General system control registers.