Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pointer authentication registers #14

Merged
merged 1 commit into from
May 17, 2023
Merged

Conversation

usugur
Copy link

@usugur usugur commented May 5, 2023

Pointer Authentication comes with ARMv8.3-A. This commit adds support for reading and writing 128-bit key registers which are referenced in Arm Architecture Reference Manual for A-profile architecture section D13.2 General system control registers.

@JaviMerino
Copy link
Contributor

I have checked these definitions against the Arm Architecture Reference Manual DDI 0487H.a. All good.

Copy link
Member

@adamgreig adamgreig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR!

We don't currently have any maintainers for this repository, so if anyone is interested in helping to review PRs and cut releases, please comment here or chat to me on Matrix, I'd be happy to get you set up.

@adamgreig
Copy link
Member

Please could you fix the rustfmt issues?

@usugur
Copy link
Author

usugur commented May 14, 2023

I couldn't see the format difference between the files added in this commit and the existing register files such as (tpidr_el2.rs). It seems that rustfmt complains about the new line between comments and the use keyword. This shouldn't be an issue as all of the register files are using the same format. Can you show that what is missing please?

@JaviMerino
Copy link
Contributor

Can you show that what is missing please?

This task failed: https://github.com/rust-embedded/aarch64-cpu/actions/runs/4896918903/jobs/8892258745?pr=14

CI must pass for this PR to be merged.

@usugur
Copy link
Author

usugur commented May 15, 2023

The format related issue has been fixed with the latest update. Could you please review and approve to enable the workflow?

@adamgreig adamgreig merged commit 7b7f4c5 into rust-embedded:main May 17, 2023
15 checks passed
@nchong-at-aws
Copy link
Contributor

We don't currently have any maintainers for this repository, so if anyone is interested in helping to review PRs and cut releases, please comment here or chat to me on Matrix, I'd be happy to get you set up.

@adamgreig Hi Adam! I'd be happy to help as a maintainer. I'm familiar with the architecture :)

@adamgreig
Copy link
Member

@nchong-at-aws great, thank you for volunteering! As the crate is owned by the rust embedded working group, would it be OK for you to join? If you open a PR to https://github.com/rust-embedded/wg#the-cortex-a-team to add your name to the list, I will approve it and you will then get access to this repo and to the crate on crates.io. There's no other responsibility beyond this crate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants