Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code not in line with description. Use comments of code to comment about code, not to give alternative code #144

Open
flip111 opened this issue Feb 17, 2019 · 0 comments

Comments

@flip111
Copy link
Contributor

flip111 commented Feb 17, 2019

https://rust-embedded.github.io/book/start/qemu.html#a-non-standard-rust-program

extern crate panic_halt;. This crate provides a panic_handler that defines the panicking behavior of the program. More on this later on.

Above that:

// pick a panicking behavior
extern crate panic_halt; // you can put a breakpoint on `rust_begin_unwind` to catch panics
// extern crate panic_abort; // requires nightly
// extern crate panic_itm; // logs messages over ITM; requires ITM support
// extern crate panic_semihosting; // logs messages to the host stderr; requires a debugger

If it's gonna be later, put it later, don't add noise in code comments.

@flip111 flip111 mentioned this issue Feb 18, 2019
bors bot added a commit that referenced this issue Mar 11, 2019
170: Update qemu.md r=adamgreig a=flip111

#144

Co-authored-by: flip111 <flip101@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant