Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

intro/install/verify.md grammatical error #184

Closed
nickgolangi opened this issue Apr 17, 2019 · 3 comments
Closed

intro/install/verify.md grammatical error #184

nickgolangi opened this issue Apr 17, 2019 · 3 comments

Comments

@nickgolangi
Copy link
Contributor

https://rust-embedded.github.io/book/intro/install/verify.html, second to last paragraph

Error:

If the commands do work with root permission then check that the udev rules has been correctly set.

Fix:

If the commands do work with root permission then check that the udev rules have been correctly set.
@nickgolangi
Copy link
Contributor Author

nickgolangi commented Apr 17, 2019 •
edited
Loading

First person (also mildly condescending tone) used in https://rust-embedded.github.io/book/start/qemu.html

Let me break down that long QEMU command for you:

@therealprof
Copy link
Contributor

@nickgolangi Thanks for noticing. Would you mind creating a pull request with your suggested fixes?

@nickgolangi nickgolangi mentioned this issue Apr 20, 2019
Merged
@nickgolangi
Copy link
Contributor Author

Done in #185.

bors bot added a commit that referenced this issue Apr 22, 2019
@bors @nickgolangi
Merge #185
de3d55f 
185: Minor fixes r=therealprof a=nickgolangi

As per issue #184.

I removed the word "long" as well, to further shift the tone from teaching toward collaboration.

Co-authored-by: nickgolangi <48889034+nickgolangi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jamesmunns @therealprof @nickgolangi