semihosting: add comment adding feature flag to panic-semihosting #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This wasn't entirely trivial to find if you've never worked with feature flags for dependencies. Hopefully it helps others out there. Signed-off-by: Antonio Gutierrez <chibby0ne@gmail.com>
|
r? @therealprof (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
S-waiting-on-review
therealprof
approved these changes
Aug 9, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Aug 9, 2019
203: semihosting: add comment adding feature flag to panic-semihosting r=therealprof a=chibby0ne This wasn't entirely trivial to find if you've never worked with feature flags for dependencies. Hopefully it helps others out there. Signed-off-by: Antonio Gutierrez <chibby0ne@gmail.com> Co-authored-by: Antonio Gutierrez <chibby0ne@gmail.com>
Build succeeded |
chibby0ne
deleted the
add_comment_on_enabling_feature_flag_panic_semihosting
branch
Centril
added a commit
to Centril/rust
that referenced
this pull request
Aug 20, 2019
Update books ## nomicon 25 commits in 8a7d05615e5bc0a7fb961b4919c44f5221ee54da..38b9a76bc8b59ac862663807fc51c9b757337fd6 2019-08-07 07:46:59 -0500 to 2019-08-19 10:04:32 -0400 - Fix transmute_copy link - some edits - drop parenthetical - clarify dangling - fix def.n of dangling - fold uninit integer rule with reading uninit memory - refactor null a bit - resolve some nits - raw ptrs must be initialized like integers - Apply suggestions from code review - explain when metadata is invalid - mention ! - add more cases of UB - avoid redundant UB - stick to broader UB for raw ptr offsets/derefs for now - be more precise about dangling - subsume the NonNull things as library types - handle recursion in the heading - Define 'producing' - NonNull, NonZero* - list more ptr offset computations - UB - Fix typo in subtyping - Add colon to `MySuperSliceable` too - Fix typo `str::mem` to `std::mem` ## reference 2 commits in b4b3536..d191a0c 2019-08-07 02:29:50 +0200 to 2019-08-15 08:42:23 +0200 - Fix warning in stable-check (rust-lang/reference#653) - our closure syntax comes from Ruby (rust-lang/reference#650) ## rust-by-example 5 commits in f2c15ba5ee89ae9469a2cf60494977749901d764..580839d90aacd537f0293697096fa8355bc4e673 2019-08-07 10:14:25 -0300 to 2019-08-17 23:17:50 -0300 - macros.md: Changing Sometime to more appropriate adverb form Sometimes (rust-lang/rust-by-example#1243) - Add colon after "See Also" (rust-lang/rust-by-example#1242) - Update enter_question_mark.md (rust-lang/rust-by-example#1208) - Add destructuring bind examples (rust-lang/rust-by-example#1238) - Change initial parameters in `fibonacci()` call. (rust-lang/rust-by-example#1241) ## embedded-book 1 commits in c5da1e11915d3f28266168baaf55822f7e3fe999..432ca26686c11d396eed6a59499f93ce1bf2433c 2019-08-05 23:02:10 +0000 to 2019-08-09 23:20:22 +0000 - semihosting: add comment adding feature flag to panic-semihosting (rust-embedded/book#203)
Centril
added a commit
to Centril/rust
that referenced
this pull request
Aug 21, 2019
Update books ## nomicon 25 commits in 8a7d05615e5bc0a7fb961b4919c44f5221ee54da..38b9a76bc8b59ac862663807fc51c9b757337fd6 2019-08-07 07:46:59 -0500 to 2019-08-19 10:04:32 -0400 - Fix transmute_copy link - some edits - drop parenthetical - clarify dangling - fix def.n of dangling - fold uninit integer rule with reading uninit memory - refactor null a bit - resolve some nits - raw ptrs must be initialized like integers - Apply suggestions from code review - explain when metadata is invalid - mention ! - add more cases of UB - avoid redundant UB - stick to broader UB for raw ptr offsets/derefs for now - be more precise about dangling - subsume the NonNull things as library types - handle recursion in the heading - Define 'producing' - NonNull, NonZero* - list more ptr offset computations - UB - Fix typo in subtyping - Add colon to `MySuperSliceable` too - Fix typo `str::mem` to `std::mem` ## reference 2 commits in b4b3536..d191a0c 2019-08-07 02:29:50 +0200 to 2019-08-15 08:42:23 +0200 - Fix warning in stable-check (rust-lang/reference#653) - our closure syntax comes from Ruby (rust-lang/reference#650) ## rust-by-example 5 commits in f2c15ba5ee89ae9469a2cf60494977749901d764..580839d90aacd537f0293697096fa8355bc4e673 2019-08-07 10:14:25 -0300 to 2019-08-17 23:17:50 -0300 - macros.md: Changing Sometime to more appropriate adverb form Sometimes (rust-lang/rust-by-example#1243) - Add colon after "See Also" (rust-lang/rust-by-example#1242) - Update enter_question_mark.md (rust-lang/rust-by-example#1208) - Add destructuring bind examples (rust-lang/rust-by-example#1238) - Change initial parameters in `fibonacci()` call. (rust-lang/rust-by-example#1241) ## embedded-book 1 commits in c5da1e11915d3f28266168baaf55822f7e3fe999..432ca26686c11d396eed6a59499f93ce1bf2433c 2019-08-05 23:02:10 +0000 to 2019-08-09 23:20:22 +0000 - semihosting: add comment adding feature flag to panic-semihosting (rust-embedded/book#203)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wasn't entirely trivial to find if you've never worked with feature
flags for dependencies. Hopefully it helps others out there.
Signed-off-by: Antonio Gutierrez chibby0ne@gmail.com