Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small critical-section-related fixes. #451

Merged
merged 3 commits into from Sep 4, 2022
Merged

Small critical-section-related fixes. #451

merged 3 commits into from Sep 4, 2022

Conversation

Dirbaio
Copy link
Member

@Dirbaio Dirbaio commented Aug 21, 2022

See individual commit messages.

@Dirbaio Dirbaio requested a review from a team as a code owner August 21, 2022 22:20
@adamgreig
Copy link
Member

While we're here, could you add the feature to the "Optional features" section of the docs in src/lib.rs please?

@Dirbaio
Copy link
Member Author

Dirbaio commented Aug 22, 2022

Done

thejpster
thejpster previously approved these changes Aug 22, 2022
View reviewed changes
Copy link
Contributor

@thejpster thejpster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

adamgreig
adamgreig requested changes Aug 22, 2022
View reviewed changes
Copy link
Member

@adamgreig adamgreig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few wording tweaks to highlight that even some single-core systems cannot use the feature, e.g. if unprivileged (see #233) or for things like softdevice or an RTOS.

src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/macros.rs Outdated Show resolved Hide resolved
@Dirbaio
Fix outdated comment in singleton!.
e0eeec4
@Dirbaio
Use a mod _export for macro reexports.
25f1f95 
This avoids having to do `#[doc(hidden)] pub mod critical_section` which is a bit strange.
adamgreig
adamgreig approved these changes Aug 22, 2022
View reviewed changes
Copy link
Member

@adamgreig adamgreig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

bors r+

bors bot added a commit that referenced this pull request Aug 22, 2022
@bors @Dirbaio
Merge #451
f17e739 
451: Small critical-section-related fixes. r=adamgreig a=Dirbaio

See individual commit messages.

Co-authored-by: Dario Nieuwenhuis <dirbaio@dirbaio.net>
@bors
Copy link
Contributor

bors bot commented Aug 22, 2022

Build failed:

@adamgreig
Copy link
Member

bors retry

@bors
Copy link
Contributor

bors bot commented Sep 4, 2022

Build succeeded:

@bors bors bot merged commit b0d2d03 into rust-embedded:master Sep 4, 2022
@adamgreig adamgreig mentioned this pull request Jan 3, 2023
Merged
bors bot added a commit that referenced this pull request Jan 4, 2023
@bors @adamgreig
Merge #458
bb4a782 
458: cortex-m v0.7.7: add documentation for critical-section-single-core r=thejpster a=adamgreig

This got missed in #448; this PR copies the documentation added in #451 to the v0.7.x branch.

Co-authored-by: Adam Greig <adam@adamgreig.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamgreig adamgreig adamgreig approved these changes

@thejpster thejpster thejpster left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Dirbaio @adamgreig @thejpster